Support Closures in getBulkActionsTdCheckboxAttributes for Improved Accessibility #2300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to pass a closure to the getBulkActionsTdCheckboxAttributes method, as it only accepts arrays. For my project, I need to pass the current row index in order to display an appropriate aria-label for each checkbox.
Changes:
The method has been adapted to accept both arrays and closures, ensuring backwards compatibility.
Alternative Considered:
Hardcoding the aria-label in the checkbox component was considered. However, this approach would require accessing the locale and handling language-specific placement of the row index, which varies (e.g., English: "select row number {{$row->id}}", German: "Zeile {{$row->id}} auswählen"). This alternative is commented out in td/bulk-actions.blade.php and forms/checkbox.blade.php.
I have not yet added documentation or new tests, as I would like to get your feedback on the proposed changes first.
All Submissions:
New Feature Submissions:
Changes to Core Features: